Skip to content

Added Python 3 compatibility#79

Open
BubaVV wants to merge 25 commits into
perone:masterfrom
BubaVV:master
Open

Added Python 3 compatibility#79
BubaVV wants to merge 25 commits into
perone:masterfrom
BubaVV:master

Conversation

@BubaVV

@BubaVV BubaVV commented Nov 29, 2016

Copy link
Copy Markdown

Now module support both Python 2.7 and 3.5+

@chadfurman

chadfurman commented Jan 9, 2017

Copy link
Copy Markdown

@BubaVV Thanks, it installed without issue (had to pip3 install future and sudo python setup.py install -- that's it). I'm new to GAs so I won't be able to test it too much. But, if it works for my use-case that will be sweet. I'll report back either way.

@chadfurman

Copy link
Copy Markdown

Was able to make it through the first tutorial. Copying their "final code" and adjusting the print statement for python3 (lol) and it worked fine

@ranisalt

Copy link
Copy Markdown

@perone stop ignoring your repo

@perone

perone commented Sep 16, 2017

Copy link
Copy Markdown
Owner

@ranisalt if you think that a pull-request with 51 files changed, without testing implemented, will be merged fast, then you'll need to review what you think that an open-source contribution is. However, you are always free to implement testing for the project and submit a pull-request. But for that you'll have to invest more effort than what you did for the complaint =)

@lczyk

lczyk commented Oct 11, 2017

Copy link
Copy Markdown

@peronoe For testing I can recommend Travis CI.

@chadfurman

Copy link
Copy Markdown

Perhaps @ranisalt will test it for us :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants